-
Notifications
You must be signed in to change notification settings - Fork 619
Update nebula rateLimit type to include perSecond and perMinute #7614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nebula rateLimit type to include perSecond and perMinute #7614
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: f82f885 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7614 +/- ##
=======================================
Coverage 56.44% 56.44%
=======================================
Files 906 906
Lines 58126 58126
Branches 4228 4228
=======================================
Hits 32811 32811
Misses 25205 25205
Partials 110 110
🚀 New features to boost your workflow:
|
size-limit report 📦
|
Merge activity
|
# Update Nebula Rate Limit Type This PR updates the Nebula rate limit type to provide more granular control by replacing the single `rateLimit` number with an object containing `perSecond` and `perMinute` properties. The change affects: - The `TeamCapabilities` type in the service-utils package - Corresponding mock data and stubs in the dashboard app - Added a changeset to document this patch update
71efe7a to
34d2fdd
Compare
9cfb3be to
f82f885
Compare

Update Nebula Rate Limit Type
This PR updates the Nebula rate limit type to provide more granular control by replacing the single
rateLimitnumber with an object containingperSecondandperMinuteproperties. The change affects:TeamCapabilitiestype in the service-utils packagePR-Codex overview
This PR focuses on updating the
rateLimittype for thenebulaobject in theservice-utilspackage. It changes therateLimitfrom a single number to an object that specifies limits per second and per minute.Detailed summary
rateLimitinpackages/service-utils/src/mocks.tsfrom a number to an object withperSecondandperMinute.rateLimitinapps/dashboard/src/@/storybook/stubs.tssimilarly.packages/service-utils/src/core/api.tsforrateLimitto reflect the new object structure.